Skip to content

feat(perf): Simplify poseidon2 cache zero-pad #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
Aug 30, 2024
Merged

feat(perf): Simplify poseidon2 cache zero-pad #5869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad9066e
simplify how we zero-pad the cache, removes an unnecessary loop and a…
vezenovm Aug 30, 2024
c5336a6
Merge branch 'master' into mv/simplify-poseidon2-cache-pad
vezenovm Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions noir_stdlib/src/hash/poseidon2.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,13 @@ impl Poseidon2 {
}

fn perform_duplex(&mut self) {
// zero-pad the cache
for i in 0..RATE {
if i >= self.cache_size {
self.cache[i] = 0;
}
}
// add the cache into sponge state
for i in 0..RATE {
self.state[i] += self.cache[i];
// We effectively zero-pad the cache by only adding to the state
// cache that is less than the specified `cache_size`
if i < self.cache_size {
self.state[i] += self.cache[i];
}
}
self.state = crate::hash::poseidon2_permutation(self.state, 4);
}
Expand Down