feat(optimization): Redirect array gets to earlier arrays if possible#5785
Closed
feat(optimization): Redirect array gets to earlier arrays if possible#5785
Conversation
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Member
|
Is this ready for review? |
Contributor
Author
|
Maybe. I'm still not sure if this optimization is worth it. Since it'd only have an effect on small programs I think due to the constant limit of how many instructions it can look past to. It also may lead to worse performance if that block parameter had a |
Contributor
Author
|
Closing this PR, it should be redundant now that we have instruction deduplication in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves comment #5772 (comment)
Summary*
This PR redirects
array_gets to work on earlier arrays if they can (currently only block parameters.This can potentially optimize code by allowing more array gets to be deduplicated but may also prevent optimizing
array_sets to be mutable if older arrays are now being used more.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.