fix: Print comptime::Value better

[jfecher]

Description

Problem*

Summary*

Several Value variants are just ids which we previously couldn't print well. I've added a helper type to hold a NodeInterner so that we can print the names of these values as well. This will now print, e.g. Eq instead of (trait definition)

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Changes to circuit sizes

Generated at commit: 4b462906282cf8ea05bbbe8a4490a7f6efed1dfd, compared to commit: e592a10d9ef76653007cc28aade4852981a48827

🧾 Summary (10% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
import	+2 ❌	+40.00%	+1 ❌	+11.11%
strings	+2 ❌	+5.26%	-11,578 ✅	-80.55%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
import	7 (+2)	+40.00%	10 (+1)	+11.11%
merkle_insert	1,803 (+24)	+1.35%	29,032 (0)	0.00%
pedersen_commitment	8 (-3)	-27.27%	28,742 (0)	0.00%
pedersen_hash	6 (+4)	+200.00%	28,742 (0)	0.00%
simple_shield	53 (+4)	+8.16%	29,032 (0)	0.00%
pedersen_check	24 (-14)	-36.84%	28,829 (-29)	-0.10%
schnorr	524 (+4)	+0.77%	54,330 (-58)	-0.11%
strings	40 (+2)	+5.26%	2,795 (-11,578)	-80.55%

[asterite]

LGTM

Is there a way to test this? (maybe it's tricky because this would be the output of a println call?)

[jfecher]

@asterite not that I know of besides testing it manually.

I'm surprised there are circuit size changes here at all though. Especially considering this is just changing the comptime values printing and not runtime ones.

[asterite]

Ah, you are right.

I just checked out the branch this PR is on top of, jf/quoted-to-trait-constraints, and I see the bump in size also happens there. I don't know why a message wasn't posted in that PR, though.

[asterite]

Nevermind, now I don't get that difference in that other PR... 🤔

[asterite]

Oh, and merging this branch against master makes it go down again... I think. We'll have to wait for the other PR to get merged, then merge against master.

[vezenovm]

Oh, and merging this branch against master makes it go down again... I think. We'll have to wait for the other PR to get merged, then merge against master.

Yeah I think so as well. If you look in the Report gates diff action you will see Downloading artifact "jf-quoted-to-trait-constraints.gates_report.json" of repository "noir-lang/noir" with ID "1761974290" under the Compare gates report step.