fix: allow trailing comma when parsing where clauses

[asterite]

Description

Problem

Resolves #4809

Summary

Also removes some duplicated parsing functions (I checked and their code was exactly the same).

Additional Context

None.

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[jfecher]

Thanks.

When the parser functions were split out into multiple files there were quite a few that weren't deleted from the original file. E.g. all of the parse_type functions. These seem to be more of those.

Also - do you mean for this to be a draft?

[asterite]

These seem to be more of those.

I can take a look at those and send a follow-up PR 👍

Also - do you mean for this to be a draft?

Oh, I usually create PRs as a draft until I see CI passing... maybe it's a left-over from my previous job: we required re-approving a PR if it was approved but more changes were pushed to it. Since we don't do this here, I guess I can ask for a review as soon as I push something, even if some minor things might be missing (like clippy, etc.)

[jfecher]

I can take a look at those and send a follow-up PR

Ah, I meant we found a few of these in the past as well and fixed them. This PR does show there could be more though.

Oh, I usually create PRs as a draft until I see CI passing... maybe it's a left-over from my previous job: we required re-approving a PR if it was approved but more changes were pushed to it. Since we don't do this here, I guess I can ask for a review as soon as I push something, even if some minor things might be missing (like clippy, etc.)

Your approach was fine - I was just curious if I was reviewing earlier than intended and was missing something. Generally before I review I like all the cargo t tests to be passing but am otherwise okay with e.g. minor clippy items being missed.