Skip to content

feat: LSP inlay parameter hints #5553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asterite merged 17 commits into from
Jul 19, 2024
Merged

feat: LSP inlay parameter hints #5553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cb9f244
Move helper functions above tests module
asterite Jul 18, 2024
f17cefe
Allow disabling type hints from initialization options
asterite Jul 18, 2024
cbb2a55
Show call parameter inlay hints
asterite Jul 18, 2024
7aa5dc4
Don't show parameter name hints when arg name matches param name
asterite Jul 18, 2024
f1f0a68
Don't show parameter name if single param name is suffix of fn name
asterite Jul 18, 2024
00bdaca
Don't show hints for param names that start with underscore
asterite Jul 18, 2024
ab166d4
Hide single letter name args with fn with just one arg
asterite Jul 18, 2024
2d24fd2
Don't show it for `other` or `value` if it's a single argument
asterite Jul 18, 2024
e936b36
Hide arg name if param name is a suffix of it
asterite Jul 18, 2024
f507b48
clippy
asterite Jul 18, 2024
6097716
Add comments to inlay hints test program
asterite Jul 18, 2024
d639907
Fix typo
asterite Jul 18, 2024
c4ad284
Correct comment
asterite Jul 18, 2024
dc671cb
Add "dont" to cspell
asterite Jul 18, 2024
a7eb1d9
Revert "Add "dont" to cspell"
asterite Jul 18, 2024
8180944
dont -> do_not
asterite Jul 18, 2024
720a87d
Merge branch 'master' into ab/lsp-inlay-parameter-name-hints
asterite Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tooling/lsp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ use requests::{
on_goto_definition_request, on_goto_type_definition_request, on_hover_request, on_initialize,
on_inlay_hint_request, on_prepare_rename_request, on_profile_run_request,
on_references_request, on_rename_request, on_shutdown, on_test_run_request, on_tests_request,
LspInitializationOptions,
};
use serde_json::Value as JsonValue;
use thiserror::Error;
Expand Down Expand Up @@ -85,7 +86,7 @@ pub struct LspState {
cached_lenses: HashMap<String, Vec<CodeLens>>,
cached_definitions: HashMap<String, NodeInterner>,
cached_parsed_files: HashMap<PathBuf, (usize, (ParsedModule, Vec<ParserError>))>,
parsing_cache_enabled: bool,
options: LspInitializationOptions,
}

impl LspState {
Expand All @@ -102,7 +103,7 @@ impl LspState {
cached_definitions: HashMap::new(),
open_documents_count: 0,
cached_parsed_files: HashMap::new(),
parsing_cache_enabled: true,
options: Default::default(),
}
}
}
Expand Down Expand Up @@ -341,7 +342,7 @@ fn prepare_source(source: String, state: &mut LspState) -> (Context<'static, 'st
}

fn parse_diff(file_manager: &FileManager, state: &mut LspState) -> ParsedFiles {
if state.parsing_cache_enabled {
if state.options.enable_parsing_cache {
let noir_file_hashes: Vec<_> = file_manager
.as_file_map()
.all_file_ids()
Expand Down
Loading