Reconstruct nested values from function#542
Merged
Conversation
Contributor
Author
|
N.B. I could not validate that this circuit is passing: https://github.com/vezenovm/aztec-circuits-noir/pull/5/files , as explained in issue #529, |
jfecher
reviewed
Nov 30, 2022
5 tasks
vezenovm
reviewed
Nov 30, 2022
Contributor
vezenovm
left a comment
There was a problem hiding this comment.
Thanks for fixing up my PR @guipublic. This is a much cleaner way of handling it, I was looking only at create_function for generating the SSA func. I should have looked at the Expression::Call branch of codegen_expression to see what happens after create_function is called.
jfecher
reviewed
Dec 1, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #492
Description
Summary of changes
Flatten data returned from a function is reconstructed into a value using the function return type.
This PR deprecate #537 I believe.
Test additions / changes
Regression test case added in 'struct' test case
Checklist
cargo fmtwith default settings.