chore: add testcase for slice equality failing in comptime interpreter#5277
chore: add testcase for slice equality failing in comptime interpreter#5277TomAFrench wants to merge 6 commits intomasterfrom
Conversation
|
This test needs to be exempted from the legacy tests for CI to pass. Sorry, wrong PR. This is part of the much larger work on getting trait dispatch & operator overloading working in the interpreter |
|
I've added an entry to ignore the legacy test. |
* master: fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code (#5009)
jfecher
left a comment
There was a problem hiding this comment.
I don't see why we're adding a failing test now rather than waiting until we add a PR to fix it to add the passing test like we usually do?
|
My thinking on this is it's generally just observability. Tests become us asserting that the compiler does what we expect rather than just "working correctly". This ensure that if the behaviour of the compiler changes in future then we'll be aware of it. |
|
@TomAFrench I can see that argument, but doesn't it apply to all known issues? I think we should just wait until traits / operator overloading is implemented in the interpreter to add this test since I don't see it being accidentally added. |
Description
Problem*
Resolves
Summary*
This PR adds a test case for #5273 which tracks whether the compile is properly handling comptime slice equalities. Once #5273 is fixed then it should be moved to
compile_success_empty.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.