Conversation
Member
|
@jfecher Shall we just add #[ignore] attribute for these so we can merge this PR? We can enable those tests when we're ready but will avoid people having to explicitly remember to add elaborator versions of any code they change. |
5 tasks
Contributor
Author
|
These bugs are fixed in #5172 (which also includes this PR) so we can just wait for that to merge. Closing this. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…5172) # Description ## Problem\* Resolves an issue where we would give a type error if a global ever used a function call in its definition. ## Summary\* This one was more difficult to fix than it seemed since fixing the main bug revealed progressively more bugs. ## Additional Context #5170 is included here as well to help me see that all tests are now passing. ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Adds the elaborator to our CI test_programs tests and frontend tests. At the time of writing this is expected to still be failing a couple tests.
After #5169 is merged, there should only be two failing tests related to globals with function calls in their RHS. We can wait to merge this PR until all tests are fixed, this PR is mostly to help track progress on CI.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.