fix(experimental elaborator): Avoid defining globals twice#5103
Merged
jfecher merged 1 commit intojf/elaborator-fixes4from May 28, 2024
Merged
fix(experimental elaborator): Avoid defining globals twice#5103jfecher merged 1 commit intojf/elaborator-fixes4from
jfecher merged 1 commit intojf/elaborator-fixes4from
Conversation
vezenovm
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Fixes the "Duplicate definitions of found" error by removing
resolve_local_globals.Summary*
Additional Context
We don't need to re-add globals to scope anymore via
resolve_local_globalssince we're not creating a new Elaborator for each function like we do for NameResolvers. The flip side of this is that I think we'll need to change how globals are stored eventually so that they're not all always visible. I think how it is now may violate imports but I'll leave that for a later fix to keep these PRs small. (and wait until I have a test case that shows it).Down to 61 errors after this PR. The errors are:
fn hash<H>(self, state: &mut H) where H: Hasher;Documentation*
Check one:
PR Checklist*
cargo fmton default settings.