Skip to content

fix(experimental elaborator): Don't check return type for trait methods#5096

Merged
jfecher merged 1 commit intojf/elaborator-fixes2from
jf/elaborator-fixes3
May 28, 2024
Merged

fix(experimental elaborator): Don't check return type for trait methods#5096
jfecher merged 1 commit intojf/elaborator-fixes2from
jf/elaborator-fixes3

Conversation

@jfecher
Copy link
Copy Markdown
Contributor

@jfecher jfecher commented May 23, 2024

Description

Problem*

Resolves some errors in the elaborator from checking a trait method's empty body against the expected type that was declared.

Summary*

Adds whether or not a function is a trait method (not a trait impl method) to the is_stub method which is just a renamed can_ignore_return_type.

Additional Context

Down to 203 errors in the stdlib.

This also fixes unused variable warnings that were present before but not shown in the error count.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher merged commit 417a69a into jf/elaborator-fixes2 May 28, 2024
@jfecher jfecher deleted the jf/elaborator-fixes3 branch May 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants