fix(experimental elaborator): Don't check return type for trait methods#5096
Merged
jfecher merged 1 commit intojf/elaborator-fixes2from May 28, 2024
Merged
fix(experimental elaborator): Don't check return type for trait methods#5096jfecher merged 1 commit intojf/elaborator-fixes2from
jfecher merged 1 commit intojf/elaborator-fixes2from
Conversation
vezenovm
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves some errors in the elaborator from checking a trait method's empty body against the expected type that was declared.
Summary*
Adds whether or not a function is a trait method (not a trait impl method) to the
is_stubmethod which is just a renamedcan_ignore_return_type.Additional Context
Down to 203 errors in the stdlib.
This also fixes unused variable warnings that were present before but not shown in the error count.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.