fix(experimental elaborator): Only add_generics once for each item#5090
Closed
fix(experimental elaborator): Only add_generics once for each item#5090
add_generics once for each item#5090Conversation
Contributor
Author
|
Wrong merge target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves an issue introduced by #5082 where
add_genericswould be called multiple times on a given item. Once when declaring the FuncMeta beforehand, and again when defining it afterward. This is an issue becauseadd_genericswill give a fresh set of generics each time. This meant the generics in a function's signature weren't the same type variables as the ones used internally, which led to type errors.Summary*
Additional Context
Down to 400 errors in the stdlib down from 1050
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.