fix: improving using-devcontainers.mdx in v0.28.0#4950
Closed
ziyinlox-purple wants to merge 2 commits intonoir-lang:masterfrom
Closed
fix: improving using-devcontainers.mdx in v0.28.0#4950ziyinlox-purple wants to merge 2 commits intonoir-lang:masterfrom
ziyinlox-purple wants to merge 2 commits intonoir-lang:masterfrom
Conversation
Contributor
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
Member
|
Can you make this change in the existing PR? It doesn't really make sense to split them up like this. |
Author
|
Sorry, this is my first attempt. Thank you for your patience and sorry for
the trouble. Now I know how to do it and I have modified it in the existing
PR.🫡
Tom French ***@***.***> 于2024年5月1日周三 17:06写道:
… Can you make this change in the existing PR? It doesn't really make sense
to split them up like this.
—
Reply to this email directly, view it on GitHub
<#4950 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A43QUXOOZGLPD5VYCFBYTI3ZACWC5AVCNFSM6AAAAABHBTYY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGE4DKMBVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #4680
Summary*
Previous:#4844
This pr is for the latest version 0.28.0
Additional Context
Update:
1.https://github.com/noir-lang/noir/blob/master/docs/docs/how_to/using-devcontainers.mdx
2. https://github.com/noir-lang/noir/blob/master/docs/versioned_docs/version-v0.28.0/how_to/using-devcontainers.mdx
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.