Skip to content

fix: de-duplicate public inputs in BB proofs#4937

Closed
guipublic wants to merge 5 commits intomasterfrom
gd/issue_4443
Closed

fix: de-duplicate public inputs in BB proofs#4937
guipublic wants to merge 5 commits intomasterfrom
gd/issue_4443

Conversation

@guipublic
Copy link
Contributor

Description

Problem*

Resolves #4443

Summary*

Barretenberg append public inputs to the proof, which are removed in Noir and prepended again before verification.
However in Noir duplicate witnesses are removed, although not in Barretenberg, which generates a discrepancy.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

I'm gonna close this PR as it should be moot after #4951.

@TomAFrench TomAFrench closed this May 1, 2024
@TomAFrench TomAFrench deleted the gd/issue_4443 branch May 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nargo fails to verify the proof (repro attached)

2 participants