Conversation
…NoteProcessor` warnings (AztecProtocol/aztec-packages#5838) Closes AztecProtocol/aztec-packages#5669, AztecProtocol/aztec-packages#5670, AztecProtocol/aztec-packages#4649 Correctly determines the signature of the autogenerated `compute_note_hash_and_nullifier` by looking up the serialized content size of notes used in the contract. Furthermore, that langth is compared against MAX_NOTE_FIELDS_LEN and a compile time error is emited if the user attempts to use a note that is bigger than currently supported. Finally changed the `NoteProcessor` warns to be errors (even thought this particular one shouldn't get that far anymore!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
chore: Improve
compute_note_hash_and_nullifierautogeneration andNoteProcessorwarnings (AztecProtocol/aztec-packages#5838)END_COMMIT_OVERRIDE