Skip to content

Adds binary(wasm) build GitHub Action for x86_64-pc-windows-wasm#476

Merged
kobyhallx merged 1 commit intonoir-lang:masterfrom
kobyhallx:kh/build-x86_64-pc-windows-wasm
Nov 17, 2022
Merged

Adds binary(wasm) build GitHub Action for x86_64-pc-windows-wasm#476
kobyhallx merged 1 commit intonoir-lang:masterfrom
kobyhallx:kh/build-x86_64-pc-windows-wasm

Conversation

@kobyhallx
Copy link
Contributor

Related issue(s)

#225 Releases don't contain binaries anymore

Resolves (link to issue)

#225 Releases don't contain binaries anymore - resolves partially as it provides Windows, wasm based binaries, others to follow.

Description

As a Developer, I would like to have access to the pre-build binary release
so that I could download system appropriate executables and start working with Noir Language.

Summary of changes

.github/workflows/publish-x86_64-pc-windows-wasm.yml - adds workflow to build binary on windows based runner. This uses static wasm build of the backend hence performance is going to be suboptimal.

Dependency additions / changes

N/A

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

N/A

Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think wasm binaries for windows is good enough at the moment. Once this PR (noir-lang/acvm-backend-barretenberg#17) is fixed and merged we can also use the barretenberg.wasm directly rather than the js cli which will be better as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants