Conversation
…ckages#5387) Requires AztecProtocol/aztec-packages#5386 Closes AztecProtocol/aztec-packages#5079 Leveraging the new `#[abi(tag)]` export attribute, the `#[aztec(storage]` and `#[aztec(note)]` decorators are now used by the aztec macros to generate exportable global structs that include storage and notes info. These are then interpreted by `noir-compiler` in the ts codegen and exposed through the contract classes. ```typescript MyContractClass.storage.my_storage_variable.slot: Fr; MyContractClass.notes.MyNote.id: Fr; ``` In the process I realized we didn't really need the `process_def_collector` pass, which has been removed (one less thing to worry about before moving to metaprogramming!) in favor of using `#[aztec(note)]` to identify notes that need to get included in the autogenerated `compute_note_hash_and_nullifier` implementation. --------- Co-authored-by: esau <152162806+sklppy88@users.noreply.github.com>
Member
|
Closing in favour of AztecProtocol/aztec-packages#5619 as we're going to get conflicts in both directions so we should sync in the direction which doesn't attempt to revert changes into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
feat!: storage_layout and
#[aztec(storage)](AztecProtocol/aztec-packages#5387)feat(acir)!: Add predicate to call opcode (AztecProtocol/aztec-packages#5616)
feat: Sync from noir (AztecProtocol/aztec-packages#5572)
feat!: contract_abi-exports (AztecProtocol/aztec-packages#5386)
feat(avm): integrate AVM with initializers (AztecProtocol/aztec-packages#5469)
feat: Restore hashing args via slice for performance (AztecProtocol/aztec-packages#5539)
END_COMMIT_OVERRIDE