Adds binary(wasm) build GitHub Action for x86_64-pc-windows-wasm#469
Closed
kobyhallx wants to merge 2 commits intonoir-lang:masterfrom
kobyhallx:kh/build--x86_64-pc-windows-wasm
Closed
Adds binary(wasm) build GitHub Action for x86_64-pc-windows-wasm#469kobyhallx wants to merge 2 commits intonoir-lang:masterfrom kobyhallx:kh/build--x86_64-pc-windows-wasm
kobyhallx wants to merge 2 commits intonoir-lang:masterfrom
kobyhallx:kh/build--x86_64-pc-windows-wasm
Conversation
jfecher
reviewed
Nov 14, 2022
|
|
||
| - name: Patch backend in crates/nargo/Cargo.toml | ||
| run: | | ||
| (Get-Content crates/nargo/Cargo.toml) -replace 'aztec_backend = { optional = true, git = "https://github.com/noir-lang/aztec_backend", rev = "01b922adcb5a9d70b2d12304e1cb7487d9f28188" }', 'aztec_backend = { optional = true, git = "https://github.com/noir-lang/aztec_backend", features = ["wasm-base"], default-features = false }' | Out-File -encoding ASCII crates/nargo/Cargo.toml |
Contributor
There was a problem hiding this comment.
Is there any way to add a wildcard to the rev here so that we don't need to update this file each time we change the aztec_backend rev in our Cargo.toml?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#225 Releases don't contain binaries anymore
Resolves (link to issue)
#225 Releases don't contain binaries anymore - resolves partially as it provides Windows, wasm based binaries, others to follow.
Description
As a Developer, I would like to have access to the pre-build binary release
so that I could download system appropriate executables and start working with Noir Language.
Summary of changes
.github/workflows/publish-x86_64-pc-windows-wasm.yml- adds workflow to build binary on windows based runner. This uses static wasm build of the backend hence performance is going to be suboptimal.Dependency additions / changes
N/A
Test additions / changes
N/A
Checklist
cargo fmtwith default settings.Additional context
N/A