chore(ci): fix long debugger test times#4599
Merged
TomAFrench merged 3 commits intomasterfrom Mar 20, 2024
Merged
Conversation
TomAFrench
commented
Mar 20, 2024
guipublic
approved these changes
Mar 20, 2024
TomAFrench
added a commit
that referenced
this pull request
Mar 27, 2024
* master: chore: delete `R1CSTransformer` (#4649) fix: Slice coercions (#4640) chore(ci): add warning sticky comment (#4647) fix(ssa): Fix slice intrinsic handling in the capacity tracker (#4643) chore: fix versioning of `bn254_blackbox_solver` crate (#4638) chore: fix acvm crates reporting errors as JS packages (#4637) chore: Release Noir(0.26.0) (#4526) chore: convert `BlockExpression` into a standard struct (#4623) chore(github): Improve PR template "document later" checkbox description (#4625) chore: Update integers.md to note support for Fields using `from_integer` (#4536) chore: update docs with function names to match version 0.25.0 specifications (#4466) feat: add specific error for attempting `string[x] = ".."` (#4611) fix(ssa): Use accurate type during SSA AsSlice simplficiation (#4610) feat: Sync from aztec-packages (#4581) chore: regression test for #2540 (#4602) chore: fix up benchmarking scripts (#4601) feat: Add experimental `quote` expression to parser (#4595) chore(ci): fix long debugger test times (#4599)
TomAFrench
added a commit
that referenced
this pull request
Apr 3, 2024
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* We're currently not closing the spawned bash process so we have to wait for the full timeout duration before the test registers as successful. This PR then adds an explicit call to `exit` to finish the test early. I've also shortened the timeout as 2 minutes seems excessive. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
We're currently not closing the spawned bash process so we have to wait for the full timeout duration before the test registers as successful. This PR then adds an explicit call to
exitto finish the test early.I've also shortened the timeout as 2 minutes seems excessive.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.