Conversation
TomAFrench
requested changes
Mar 14, 2024
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
This is reverting changes from this repository.
…#5217) The AVM cannot support setting constants of field size (because the whole instruction has to fit in a field). To align Brillig with AVM bytecode, I'm changing bytecode emission for the case where the constant is > 128 bits. The current change splits the field into two 128bit limbs, and then multiplies and adds.
…#5217) The AVM cannot support setting constants of field size (because the whole instruction has to fit in a field). To align Brillig with AVM bytecode, I'm changing bytecode emission for the case where the constant is > 128 bits. The current change splits the field into two 128bit limbs, and then multiplies and adds.
Split brillig IR in low level instructions and higher level codegen files that compose the instructions and restrict visibilities. This should not have any business logic change. This also fixes debug_show by only printing the low level instructions, previously we were printing both the high level codegen and the low level instructions and it was a mess to read.
Split brillig IR in low level instructions and higher level codegen files that compose the instructions and restrict visibilities. This should not have any business logic change. This also fixes debug_show by only printing the low level instructions, previously we were printing both the high level codegen and the low level instructions and it was a mess to read.
--------- Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
--------- Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
Contributor
|
It's completely broken :/ |
added 2 commits
March 15, 2024 12:18
…mage (AztecProtocol/aztec-packages#5222) Checks that the msg.sender in initializer calls matches the deployer address defined in the address preimage, unless when it's set to zero.
…mage (AztecProtocol/aztec-packages#5222) Checks that the msg.sender in initializer calls matches the deployer address defined in the address preimage, unless when it's set to zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
feat: Check initializer msg.sender matches deployer from address preimage (AztecProtocol/aztec-packages#5222)
feat: Sync from noir (AztecProtocol/aztec-packages#5234)
feat: Brillig IR refactor (AztecProtocol/aztec-packages#5233)
feat(avm): brillig CONST of size > u128 (AztecProtocol/aztec-packages#5217)
feat: New brillig field operations and refactor of binary operations (AztecProtocol/aztec-packages#5208)
feat!: Support contracts with no constructor (AztecProtocol/aztec-packages#5175)
END_COMMIT_OVERRIDE