Merged
Conversation
added 3 commits
March 1, 2024 21:09
Injects the initialization check by default on every aztec private function for contracts that have initializers.
TomAFrench
approved these changes
Mar 4, 2024
* master: chore: export `report_errors` from `nargo` (#4461) feat: add option to set max memory for bb.js (#4227) feat: backpropagate constants in ACIR during optimization (#3926) feat: skip redundant range checks in brillig (#4460) fix: Variables from trait constraints being permanently bound over when used within a trait impl (#4450) feat: Add overflow and underflow checks for unsigned integers in brillig (#4445) fix(flake): stop flake.nix removing ignored-tests.txt (#4455) fix: build noir_codegen when publishing (#4448) chore: only ignore Nargo.toml in `test_programs` directory and not su… (#4451) chore: create parser specifically for function visibility (#4425) chore: Document BoundedVec (#4430) chore: split up parser into separate files for code organisation (#4420) feat: Sync from aztec-packages (#4444) chore!: reserve `unchecked` keyword (#4432) chore: address code review comments of PR4398 (#4435) feat: Sync from aztec-packages (#4439) feat: Sync from aztec-packages (#4438)
added 6 commits
March 5, 2024 00:47
This import is unnecessary as we can just use the full path to the various items we're using from `dep:aztec`
This import is unnecessary as we can just use the full path to the various items we're using from `dep:aztec`
* Get rid of `boxes-files` job as unbox command was removed from aztec-cli. * Get rid of `yarn-project-base`. Attempting to skip dependency downloads was a bit of a false economy and was quite a bit of complication. * `ecr_login` more explicitly, rather than every time we call `extract_repo`. * We flatten the yarn-project jobs a bit. This means we do repeat work (bootstrapping), but can better parallelise jobs. * Remove all `.dockerignore` files from the repo, and ignore them from git. Instead we compute the file from git when building in CI or using `bootstrap_docker.sh`. This is much less error prone, and means when testing building images locally we're getting the same as in CI. New script is `create_docker_ignore`. * Add `--platform=linux/amd` in some `FROM` directives where arch doesn't matter, to improve fast bootstrap on arm systems. * `build_local` logs into ecr just once. * Add `[ci no-term <repo>]` option which allows connection to aws build instances for debugging. (They still get reaped after 20m). * Remove `l1-contracts` installing submodule deps in dockerfile. It's expected this to have been done before building the image by the build-system. * Remove `end-to-end/scripts/docker-compose-browser.yml` and start script, seems this was a workaround from some alpine build stuff, but we just build using ubuntu now. * Remove `unlimited` from number of jobs. Having this actually crashed my mac when running the tests. By default we still use half the cores, which is fine as each test suite runs tests in parallel as well.
* Get rid of `boxes-files` job as unbox command was removed from aztec-cli. * Get rid of `yarn-project-base`. Attempting to skip dependency downloads was a bit of a false economy and was quite a bit of complication. * `ecr_login` more explicitly, rather than every time we call `extract_repo`. * We flatten the yarn-project jobs a bit. This means we do repeat work (bootstrapping), but can better parallelise jobs. * Remove all `.dockerignore` files from the repo, and ignore them from git. Instead we compute the file from git when building in CI or using `bootstrap_docker.sh`. This is much less error prone, and means when testing building images locally we're getting the same as in CI. New script is `create_docker_ignore`. * Add `--platform=linux/amd` in some `FROM` directives where arch doesn't matter, to improve fast bootstrap on arm systems. * `build_local` logs into ecr just once. * Add `[ci no-term <repo>]` option which allows connection to aws build instances for debugging. (They still get reaped after 20m). * Remove `l1-contracts` installing submodule deps in dockerfile. It's expected this to have been done before building the image by the build-system. * Remove `end-to-end/scripts/docker-compose-browser.yml` and start script, seems this was a workaround from some alpine build stuff, but we just build using ubuntu now. * Remove `unlimited` from number of jobs. Having this actually crashed my mac when running the tests. By default we still use half the cores, which is fine as each test suite runs tests in parallel as well.
TomAFrench
approved these changes
Mar 5, 2024
Implement internal functions as a macro. Internal functions are now written with an `aztec(internal)` decorator as opposed to the `internal` keyword. --------- Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Implement internal functions as a macro. Internal functions are now written with an `aztec(internal)` decorator as opposed to the `internal` keyword. --------- Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
reviewed
Mar 5, 2024
TomAFrench
added a commit
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: Internal as a macro (AztecProtocol/aztec-packages#4898)
chore: remove import of
dep::aztecfrom aztec_macros (AztecProtocol/aztec-packages#4941)fix: noir test incorrect reporting (AztecProtocol/aztec-packages#4925)
END_COMMIT_OVERRIDE