Skip to content

Adds binary x86_64-apple-darwin #446

Merged
jfecher merged 1 commit intonoir-lang:masterfrom
kobyhallx:kh/binary-x86_64-apple-darwin
Nov 8, 2022
Merged

Adds binary x86_64-apple-darwin #446
jfecher merged 1 commit intonoir-lang:masterfrom
kobyhallx:kh/binary-x86_64-apple-darwin

Conversation

@kobyhallx
Copy link
Contributor

Add binary build GitHub Action for x86_64-apple-darwin target (Apple Mac on Intel CPU)

Related issue(s)

#225 Releases don't contain binaries anymore

Resolves (link to issue)

#225 Releases don't contain binaries anymore - resolves partially as it provides Mac Intel only, others to follow.

Description

As a Developer, I would like to have access to the pre-build binary release
so that I could download system appropriate executables and start working with Noir Language.

Summary of changes

.github/workflows/publish-x86_64-apple-darwin.yml where the base of GitHub Action is defined
.github/build-x86_64-apple-darwin where shell script is defined to compile releasable binary along with std_lib contents

Dependency additions / changes

N/A

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

N/A

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me for now. Eventually I'd like to have clang+llvm 13.0 working as well

Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one note for reference sake

@guipublic
Copy link
Contributor

Is my understanding correct?
This file .github/workflows/publish-x86_64-apple-darwin.yml generates the binaries during git CI
It uses .github/build-x86_64-apple-darwin in order to build them

Then where are located the binaries, can a user download them from the repo?

@kobyhallx kobyhallx requested a review from jfecher November 8, 2022 11:16
@kobyhallx
Copy link
Contributor Author

kobyhallx commented Nov 8, 2022

Is my understanding correct? This file .github/workflows/publish-x86_64-apple-darwin.yml generates the binaries during git CI It uses .github/build-x86_64-apple-darwin in order to build them

Then where are located the binaries, can a user download them from the repo?

@guipublic your understanding is correct:

  1. .github/workflows/publish-x86_64-apple-darwin.yml is kicked on push with a tag starting with v*, eg. v0.0.15
  2. .github/build-x86_64-apple-darwin is really a convenience script called from 1
  3. binary is built and
  4. upload to release created with that said tag

Once this sequence is successfully executed a user can download the binary from Release/assets section.

@jfecher
Copy link
Contributor

jfecher commented Nov 8, 2022

👍 LGTM, lets merge it

@jfecher jfecher merged commit e885d42 into noir-lang:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants