fix: Remove hack in increment_array_reference_count#4265
Merged
jfecher merged 1 commit intojf/fix-incrc-assignfrom Feb 5, 2024
Merged
fix: Remove hack in increment_array_reference_count#4265jfecher merged 1 commit intojf/fix-incrc-assignfrom
jfecher merged 1 commit intojf/fix-incrc-assignfrom
Conversation
5 tasks
vezenovm
changed the title
jfecher
approved these changes
Feb 5, 2024
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
I'm not entirely sure if this will pass all cases but I think it is good to merge since it passes the test cases we do know about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
A followup to #4210
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.