chore(ci): fix publishing of noir_wasm#4163
Merged
kevaundray merged 1 commit intomasterfrom Jan 25, 2024
Merged
Conversation
kevaundray
approved these changes
Jan 25, 2024
5 tasks
kevaundray
pushed a commit
that referenced
this pull request
Jan 25, 2024
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* This PR fixes an issue in #4163 where the job dependency was mistyped. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #4157
Summary*
#3891 didn't update release flow so it's still trying to build
noir_wasmusing nix. This PR updates to use the new build process.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.