feat: rewrite constraints on binary instructions in terms of their inputs#4064
Closed
TomAFrench wants to merge 1 commit intomasterfrom
Closed
feat: rewrite constraints on binary instructions in terms of their inputs#4064TomAFrench wants to merge 1 commit intomasterfrom
TomAFrench wants to merge 1 commit intomasterfrom
Conversation
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
9ff50fb to
bd60004
Compare
1874a1e to
ffe43a1
Compare
5f709d7 to
a54c1b8
Compare
8313eed to
dd450c3
Compare
dd450c3 to
fac2a3e
Compare
a54c1b8 to
af0e04f
Compare
76655c2 to
cad8249
Compare
cad8249 to
42d200e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Description
Problem*
Resolves
Summary*
This PR is blocked by #4065 and #4060 as otherwise we get a large number of duplicated constraints from multiple constraints being decomposed into the same base set of constraints.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.