Skip to content

chore(ci): install fixed version of wasm-pack in CI#4034

Merged
TomAFrench merged 2 commits intomasterfrom
tf/install-wasm-opt
Jan 12, 2024
Merged

chore(ci): install fixed version of wasm-pack in CI#4034
TomAFrench merged 2 commits intomasterfrom
tf/install-wasm-opt

Conversation

@TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jan 12, 2024

Description

Problem*

Resolves

Summary*

Let's provide a fixed version of wasm-pack in CI rather than just allowing yarn to install it when it realises that it doesn't exist.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore(ci): install wasm-opt in CI chore(ci): install fixed version of wasm-pack in CI Jan 12, 2024
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit 5ff5136 Jan 12, 2024
@TomAFrench TomAFrench deleted the tf/install-wasm-opt branch January 12, 2024 18:21
TomAFrench added a commit that referenced this pull request Jan 13, 2024
* master:
  feat: add `noir-compiler` checks to `aztec_macros` (#4031)
  chore: remove unnecessary visibility modifiers from u128 trait impls (#4023)
  chore(ci): install fixed version of `wasm-pack` in CI (#4034)
  chore: remove `release-tests` package (#4032)
  chore(docs): bumping playground version (#4030)
  fix: allow ast when macro errors (#4005)
  chore: provide a canonical "failing" `BlackBoxFunctionSolver` (#4028)
  feat: assert maximum bit size when creating a U128 from an integer (#4024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants