chore: move module related code from fm to noirc-frontend#3806
Merged
TomAFrench merged 4 commits intomasterfrom Dec 14, 2023
Merged
chore: move module related code from fm to noirc-frontend#3806TomAFrench merged 4 commits intomasterfrom
fm to noirc-frontend#3806TomAFrench merged 4 commits intomasterfrom
Conversation
kevaundray
approved these changes
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
AztecBot
pushed a commit
that referenced
this pull request
Jan 3, 2024
sirasistant
pushed a commit
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #3799
Summary*
This is a relatively quick and dirty resolution to #3799. We may want to integrate these functions into
ModCollectoras methods but I think they also work standalone plus it means that we can transfer the tests across without needing to create aModCollectorinstance.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.