feat: Implement print without newline by grasshopper47 · Pull Request #3650 · noir-lang/noir

grasshopper47 · 2023-11-30T20:26:23Z

Description

Problem*

Resolves #3575
Resolves #2912 (duplicate)

Continuation of #3576

Summary*

Refactors println_oracle method into print with boolean indicator, allowing print to coexist with println under the same ForeignCall string symbol.
Updates appropriate tests, and logging.md documentation.
Add a subchapter to 03_string.md documentation for the fmtstr type

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

grasshopper47 · 2023-11-30T20:59:38Z

@jfecher any idea here:

jfecher · 2023-12-01T21:41:04Z

@TomAFrench do you know why this check is failing?

kevaundray · 2023-12-01T21:49:22Z

Likely this is to do with the fact that this is being ran on a fork -- we can merge if all else looks good

TomAFrench · 2023-12-01T22:11:19Z

Yep, that's a fork issue.

docs/docs/standard_library/logging.md

test_programs/execution_success/strings/src/main.nr

tooling/nargo/src/ops/foreign_calls.rs

jfecher

LGTM, thanks for keeping up with all the suggestions!

tooling/nargo/src/ops/foreign_calls.rs

kevaundray · 2023-12-04T19:06:43Z

Test / Test on ubuntu (pull_request) is failing, can force merge once that is fixed

grasshopper47 · 2023-12-04T20:42:25Z

Test / Test on ubuntu (pull_request) is failing, can force merge once that is fixed

I've swapped the order of the oracle args to be safe(r).

@jfecher what say you? :)

grasshopper47 · 2023-12-04T21:25:56Z

JS Tests failing

IDK about this, @TomAFrench @kevaundray ?

grasshopper47 · 2023-12-05T13:16:11Z

@jfecher I think the auto-merge got disabled since my last push

🤖 I have created a release *beep* *boop* --- <details><summary>0.21.0</summary> ## [0.21.0](v0.20.0...v0.21.0) (2023-12-15) ### ⚠ BREAKING CHANGES * remove unused `source-resolver` package ([#3791](#3791)) * Make file manager read-only to the compiler ([#3760](#3760)) ### Features * Add `prelude.nr` ([#3693](#3693)) ([5f0f81f](5f0f81f)) * Add some traits to the stdlib ([#3796](#3796)) ([8e11352](8e11352)) * Add support for writing tracing debug info to file ([#3790](#3790)) ([98a5004](98a5004)) * Allow passing custom foreign call handlers when creating proofs in NoirJS ([#3764](#3764)) ([6076e08](6076e08)) * Allow underscores in integer literals ([#3746](#3746)) ([2c06a64](2c06a64)) * Avoid overflow checks on boolean multiplication ([#3745](#3745)) ([9b5b686](9b5b686)) * Aztec-packages ([#3754](#3754)) ([c043265](c043265)) * Dockerfile to test cargo and JS packages ([#3684](#3684)) ([513d619](513d619)) * Docs landing page with a playground ([#3667](#3667)) ([9a95fbe](9a95fbe)) * Enhance test information output ([#3696](#3696)) ([468fbbc](468fbbc)) * Implement print without newline ([#3650](#3650)) ([9827dfe](9827dfe)) * **lsp:** Add goto definition for locals ([#3705](#3705)) ([9dd465c](9dd465c)) * **lsp:** Add goto definition for structs ([#3718](#3718)) ([a576c5b](a576c5b)) * Optimize out unnecessary truncation instructions ([#3717](#3717)) ([c9c72ae](c9c72ae)) * Remove experimental feature warning for traits ([#3783](#3783)) ([cb52242](cb52242)) * Reorganizing docs to fit diataxis framework ([#3711](#3711)) ([54a1ed5](54a1ed5)) * Simplify explicit equality assertions to assert equality directly ([#3708](#3708)) ([2fc46e2](2fc46e2)) * Speed up transformation of debug messages ([#3815](#3815)) ([2a8af1e](2a8af1e)) ### Bug Fixes * `try_unify` no longer binds types on failure ([#3697](#3697)) ([f03e581](f03e581)) * Add missing assertion to test ([#3765](#3765)) ([bcbe116](bcbe116)) * Add negative integer literals ([#3690](#3690)) ([8b3a68f](8b3a68f)) * Allow trait method references from the trait name ([#3774](#3774)) ([cfa34d4](cfa34d4)) * Deserialize odd length hex literals ([#3747](#3747)) ([4000fb2](4000fb2)) * **docs:** Trigger `update-docs` workflow when the `release-please` PR gets merged and not on every merge to master ([#3677](#3677)) ([9a3d1d2](9a3d1d2)) * Initialise strings as u8 array ([#3682](#3682)) ([8da40b7](8da40b7)) * **lsp:** Package resolution on save ([#3794](#3794)) ([14f2fff](14f2fff)) * Parse negative integer literals ([#3698](#3698)) ([463ab06](463ab06)) * Pub is required on return for entry points ([#3616](#3616)) ([7f1d796](7f1d796)) * Remove `noirc_driver/aztec` feature flag in docker ([#3784](#3784)) ([a48d562](a48d562)) * Remove include-keys option ([#3692](#3692)) ([95d7ce2](95d7ce2)) * Revert chnage to modify version in workspace file for acvm dependencies ([#3673](#3673)) ([0696f75](0696f75)) * Sequence update-lockfile workflow so it gets modified after the ACVM version in the root has been changed ([#3676](#3676)) ([c00cd85](c00cd85)) * **ssa:** Handle array arguments to side effectual constrain statements ([#3740](#3740)) ([028d65e](028d65e)) * Stop cloning Traits! ([#3736](#3736)) ([fcff412](fcff412)) * Stop issuing unused variable warnings for variables in trait definitions ([#3797](#3797)) ([0bb44c3](0bb44c3)) * Unsigned integers cannot be negated ([#3688](#3688)) ([f904ae1](f904ae1)) ### Miscellaneous Chores * Make file manager read-only to the compiler ([#3760](#3760)) ([e3dcc21](e3dcc21)) * Remove unused `source-resolver` package ([#3791](#3791)) ([57d2505](57d2505)) </details> <details><summary>0.37.1</summary> ## [0.37.1](v0.37.0...v0.37.1) (2023-12-15) ### Features * Aztec-packages ([#3754](#3754)) ([c043265](c043265)) * Speed up transformation of debug messages ([#3815](#3815)) ([2a8af1e](2a8af1e)) ### Bug Fixes * Deserialize odd length hex literals ([#3747](#3747)) ([4000fb2](4000fb2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Savio-Sou · 2024-01-05T19:57:48Z

cc @signorecello for the minor doc changes ICYMI

signorecello · 2024-01-08T10:04:36Z

Very useful and nicely documented, thanks!

grasshopper47 changed the title ~~Feat implement print without newline~~ feat: Implement print without newline Nov 30, 2023

grasshopper47 force-pushed the feat-implement-print-without-newline branch from 6ccbe09 to 00010cb Compare November 30, 2023 20:48

jfecher reviewed Dec 4, 2023

View reviewed changes

docs/docs/standard_library/logging.md Outdated Show resolved Hide resolved

test_programs/execution_success/strings/src/main.nr Outdated Show resolved Hide resolved

tooling/nargo/src/ops/foreign_calls.rs Outdated Show resolved Hide resolved

jfecher approved these changes Dec 4, 2023

View reviewed changes

jfecher enabled auto-merge December 4, 2023 17:58

jfecher disabled auto-merge December 4, 2023 18:00

jfecher reviewed Dec 4, 2023

View reviewed changes

tooling/nargo/src/ops/foreign_calls.rs Outdated Show resolved Hide resolved

jfecher approved these changes Dec 4, 2023

View reviewed changes

jfecher enabled auto-merge December 4, 2023 18:10

grasshopper47 and others added 10 commits December 4, 2023 21:17

Refactor ForeignCalls println to print with bool

0685627

Add a print statement alongisde println in tests

eebf7c1

Refactor to mention print method

76d3f4d

Mention formatted strings

db8117c

Addendum print comment

60dc130

Update docs/docs/standard_library/logging.md

909d4ec

Update test_programs/execution_success/strings/src/main.nr

cd23230

Update tooling/nargo/src/ops/foreign_calls.rs

967d32e

Update tooling/nargo/src/ops/foreign_calls.rs

3eecd07

Swap newline and ident T args in print oracle

e22cbc5

auto-merge was automatically disabled December 4, 2023 20:39
Head branch was pushed to by a user without write access

grasshopper47 force-pushed the feat-implement-print-without-newline branch from e9c64a4 to e22cbc5 Compare December 4, 2023 20:39

cargo fmt

41a5d7f

Merge branch 'master' into feat-implement-print-without-newline

5b324fd

vezenovm enabled auto-merge December 5, 2023 17:05

vezenovm added this pull request to the merge queue Dec 5, 2023

Merged via the queue into noir-lang:master with commit 9827dfe Dec 5, 2023

kevaundray mentioned this pull request Dec 5, 2023

chore: Release Noir(0.21.0) #3672

Closed

vezenovm mentioned this pull request Dec 5, 2023

Implement print builtin that does not insert a newline #2912

Closed

kevaundray mentioned this pull request Dec 15, 2023

chore: Release Noir(0.21.0) #3824

Merged

Savio-Sou added the documentation Improvements or additions to documentation label Jan 5, 2024

Conversation

grasshopper47 commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

grasshopper47 commented Nov 30, 2023

Uh oh!

jfecher commented Dec 1, 2023

Uh oh!

kevaundray commented Dec 1, 2023

Uh oh!

TomAFrench commented Dec 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jfecher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevaundray commented Dec 4, 2023

Uh oh!

grasshopper47 commented Dec 4, 2023

Uh oh!

grasshopper47 commented Dec 4, 2023

Uh oh!

grasshopper47 commented Dec 5, 2023

Uh oh!

Savio-Sou commented Jan 5, 2024

Uh oh!

signorecello commented Jan 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

grasshopper47 commented Nov 30, 2023 •

edited

Loading