chore(ci): ensure that acir artifacts are published on master#3367
Merged
kevaundray merged 1 commit intomasterfrom Oct 30, 2023
Merged
chore(ci): ensure that acir artifacts are published on master#3367kevaundray merged 1 commit intomasterfrom
kevaundray merged 1 commit intomasterfrom
Conversation
kevaundray
approved these changes
Oct 30, 2023
Member
Author
|
Looks like this hasn't done the trick 🤔 |
5 tasks
TomAFrench
added a commit
that referenced
this pull request
Oct 31, 2023
* master: (86 commits) chore: Add a workflow to build with feature flag (#3378) chore: fix for-loop in aztec-library (#3377) feat!: return Pedersen structure in stdlib (#3190) feat: Manage breakpoints and allow restarting a debugging session (#3325) chore: small driver refactors (#3375) fix: fixing versioning workflow (#3296) feat!: noir-wasm outputs debug symbols (#3317) chore: build acvm_js for integration tests in parallel (#3368) chore: replace bash with `@actions/github-script` (#3369) feat(noir_js): allow providing foreign call handlers in noirJS (#3294) feat: Allow traits to have generic functions (#3365) chore(ci): ensure that acir artifacts are published on master (#3367) chore: cleanup CI workflows to be more consistent (#3366) fix: Use pedersen_hash for merkle tree (#3357) chore: format `for` stmt (#3333) fix!: move mimc to hash submodule (#3361) fix: remove sha2_block test (#3360) chore: deduplicate dependencies across the workspace (#3356) chore: Add links to complete NoirJS app code to the guide (#3359) chore: clippy fixes (#3358) ...
TomAFrench
added a commit
that referenced
this pull request
Oct 31, 2023
* mv/slice-struct-fields: (112 commits) chore: Add a workflow to build with feature flag (#3378) chore: fix for-loop in aztec-library (#3377) feat!: return Pedersen structure in stdlib (#3190) feat: Manage breakpoints and allow restarting a debugging session (#3325) chore: small driver refactors (#3375) fix: fixing versioning workflow (#3296) feat!: noir-wasm outputs debug symbols (#3317) chore: build acvm_js for integration tests in parallel (#3368) chore: replace bash with `@actions/github-script` (#3369) feat(noir_js): allow providing foreign call handlers in noirJS (#3294) feat: Allow traits to have generic functions (#3365) chore(ci): ensure that acir artifacts are published on master (#3367) chore: cleanup CI workflows to be more consistent (#3366) fix: Use pedersen_hash for merkle tree (#3357) chore: format `for` stmt (#3333) fix!: move mimc to hash submodule (#3361) fix: remove sha2_block test (#3360) chore: deduplicate dependencies across the workspace (#3356) chore: Add links to complete NoirJS app code to the guide (#3359) chore: clippy fixes (#3358) ...
TomAFrench
added a commit
that referenced
this pull request
Oct 31, 2023
* master: (61 commits) feat: Add generic count check for trait methods (#3382) feat!: avoid integer overflows (#2713) chore: Add a workflow to build with feature flag (#3378) chore: fix for-loop in aztec-library (#3377) feat!: return Pedersen structure in stdlib (#3190) feat: Manage breakpoints and allow restarting a debugging session (#3325) chore: small driver refactors (#3375) fix: fixing versioning workflow (#3296) feat!: noir-wasm outputs debug symbols (#3317) chore: build acvm_js for integration tests in parallel (#3368) chore: replace bash with `@actions/github-script` (#3369) feat(noir_js): allow providing foreign call handlers in noirJS (#3294) feat: Allow traits to have generic functions (#3365) chore(ci): ensure that acir artifacts are published on master (#3367) chore: cleanup CI workflows to be more consistent (#3366) fix: Use pedersen_hash for merkle tree (#3357) chore: format `for` stmt (#3333) fix!: move mimc to hash submodule (#3361) fix: remove sha2_block test (#3360) chore: deduplicate dependencies across the workspace (#3356) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
We're currently never publishing ACIR artifacts on master as seen in this CI run: https://github.com/noir-lang/noir/actions/runs/6699174556/job/18202815460
The issue seems to be a matter of quotation marks in the if statement so this PR removes them.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.