fix(noirc_errors): Switch update_acir to use for-loop instead of iter

[vezenovm]

Description

Problem*

Some context here: #2645 (comment)

Iterators are lazy in Rust. In update_acir we did not use the iterator for new_locations. This means we are calling mem::take on our location data, but never inserting back into it, thus removing all our runtime location data.

Summary*

Documentation

• This PR requires documentation updates when merged.

  • I will submit a noir-lang/docs PR.
  • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[TomAFrench]

I've got an existing PR for this here: #2643

[vezenovm]

@TomAFrench oops I missed that thanks!