Skip to content

chore: Remove set_value_from_id and resolve in the DataFlowGraph#2498

Closed
jfecher wants to merge 3 commits intomasterfrom
jf/remove-resolve
Closed

chore: Remove set_value_from_id and resolve in the DataFlowGraph#2498
jfecher wants to merge 3 commits intomasterfrom
jf/remove-resolve

Conversation

@jfecher
Copy link
Contributor

@jfecher jfecher commented Aug 30, 2023

Description

Problem*

Resolves (none)

Summary*

This is another experimental change in the SSA IR. This one is aimed at reducing the surface for bugs by removing DataFlowGraph::set_value_from_id and subsequently the need to call DataFlowGraph::resolve for each value as well. This has historically been a source of bugs when one forgets to call resolve. Now that the mem2reg no longer relies on set_value_from_id, the only passes that still use it are cfg simplification which just needed a small change, and defunctionalization which still needs a larger change.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher
Copy link
Contributor Author

jfecher commented Dec 15, 2023

This would require reworks to several passes that are too large to be practical currently.

@jfecher jfecher closed this Dec 15, 2023
@TomAFrench TomAFrench deleted the jf/remove-resolve branch January 8, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant