chore: pull acvm-backend-barretenberg into main Noir repo#2495
Merged
TomAFrench merged 3 commits intomasterfrom Aug 31, 2023
Merged
chore: pull acvm-backend-barretenberg into main Noir repo#2495TomAFrench merged 3 commits intomasterfrom
acvm-backend-barretenberg into main Noir repo#2495TomAFrench merged 3 commits intomasterfrom
Conversation
TomAFrench
force-pushed
the
monorepo-backend
branch
2 times, most recently
from
07f9686 to
8e7078d
Compare
kobyhallx
approved these changes
Aug 31, 2023
Contributor
kobyhallx
left a comment
kobyhallx
left a comment
There was a problem hiding this comment.
lgtm for temp situation
TomAFrench
added a commit
that referenced
this pull request
Sep 1, 2023
* master: (47 commits) fix: Initialize structs during def collection, not name resolution (#2528) feat: Apply optimizations to unconstrained code (#2348) chore(ci): Distinguish between expected failures and compiler panics in `compile_failure` tests. (#2518) chore: improve types in `acvm-backend-barretenberg` (#2516) feat(aztec_noir): abstract kernel return types (#2521) chore: remove usage of `Backend` trait (#2514) chore: delete `ProveAndVerifyCommand` (#2520) chore: Remove dead code from `acvm_backend_barretenberg` (#2512) chore: only install `tokio-util` dependency on windows (#2425) chore(aztec_noir): imply the open keyword (#2508) chore: pull `acvm-backend-barretenberg` into main Noir repo (#2495) chore: clippy fix (#2507) chore: check if the noir aztec library is installed (#2505) chore: update ACIR artifacts (#2503) chore!: Update to `acvm-backend-barretenberg` v0.12.0 (#2377) fix: Bring back accidentally deleted double_verify_proof test. (#2501) chore(aztec_noir): import aztec library if not found yet (#2492) chore(abi)!: Replace struct name with fully qualified struct path (#2374) chore!: Remove keys from preprocessed artifacts (#2283) chore(noir): Release 0.10.5 (#2482) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2523.
Summary*
This is a temporary step which allows us to progress on proper dynamic backends more easily and removes a layer of indirection between ACVM and Noir.
Draft PR as I want to clean things up more.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.