Skip to content

fix: Closure lvalue capture bugfix #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfecher merged 2 commits into from
Aug 28, 2023
Merged

fix: Closure lvalue capture bugfix #2457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
217cb7f
fix: make closure env ast::Ident mutable
Aug 28, 2023
8cbcb19
test: add test for lvalue capture
Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions crates/nargo_cli/tests/execution_success/closures_mut_ref/src/main.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,17 @@ fn main(mut x: Field) {
add2(&mut x);
assert(x == 3);

issue_2120();
}

// https://github.com/noir-lang/noir/issues/2120
fn issue_2120() {
let x1 = &mut 42;
let set_x1 = |y| { *x1 = y; };

assert(*x1 == 42);
set_x1(44);
assert(*x1 == 44);
set_x1(*x1);
assert(*x1 == 44);
}
2 changes: 1 addition & 1 deletion crates/noirc_frontend/src/monomorphization/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ impl<'interner> Monomorphizer<'interner> {
});

let location = None; // TODO: This should match the location of the lambda expression
let mutable = false;
let mutable = true;
let definition = Definition::Local(env_local_id);

let env_ident = ast::Ident {
Expand Down