fix(ssa): codegen missing check for unary minus#2413
Merged
jfecher merged 4 commits intonoir-lang:masterfrom Aug 25, 2023
Merged
fix(ssa): codegen missing check for unary minus#2413jfecher merged 4 commits intonoir-lang:masterfrom
jfecher merged 4 commits intonoir-lang:masterfrom
Conversation
jfecher
requested changes
Aug 24, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
It looks like the only place we generae Unary expressions outside of monomorphizing Prefix expressions is when evaluating zeroed_value_of_type. Can you add a span to that call instead so we don't have to have an optional span here?
Contributor
Author
|
I've added location to ast::Unary. We also generate implicit references/dereferences during type-checking, which also needed locations in the node_interner, or else we'd crash when trying to access the location when creating the corresponding ast::Unary |
TomAFrench
added a commit
that referenced
this pull request
Aug 25, 2023
* master: fix: Implement new mem2reg pass (#2420) feat(nargo): Support optional directory in git dependencies (#2436) fix(acir_gen): Pass accurate contents to slice inputs for bb func calls (#2435) fix(ssa): codegen missing check for unary minus (#2413) fix(lsp): Remove duplicated creation of lenses (#2433) feat: Add `test(should_fail)` attribute for tests that are meant to fail (#2418) chore: improve error message for InternalError (#2429) chore: Add stdlib to every crate as it is added to graph (#2392)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2412
Summary*
For normal binary expression we call
FunctionContext::insert_binarywhich inserts a binary instruction and checks if truncation is needed.However, for unary minus we directly call into the
FunctionBuilderwhich skips this check -- this PR replaces that function call with a call toFunctionContext::insert_binary.The
locationargument inFunctionContext::insert_binaryis also made optional sinceast::Unarydoesn't have a location and it would be a bit of a pain to add it, because in mono we sometimes generate unary expressions on the fly.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.