feat(acir_gen): Use predicates with MemoryOps

[vezenovm]

Description

Problem*

Resolves #2133

Summary*

The ACVM was missing a predicate as part of MemoryOps, thus we were pushing MemoryOps in ACIR gen without their predicate. This caused memory operations under dynamic predicates to be executed no matter what. This is a bug as we can error out with an index out of bounds for valid execution. The linked issue has a full example of this and I have expanded the dynamic_index_failure test:

fn main(mut x: [u32; 5], z: Field) {
    let idx = z + 10;
    
    if z == 20 {
        x[0] = x[4];
    } else {
        // We should not hit out of bounds here as we have a predicate
        // that should not be hit
        if idx as u32 < 3 {
            x[idx] = 10;
        }
    }
    // Error should occur here as an index out of bounds read occurs 
    assert(x[idx] != 0);
}

Patches:
Backend branch: noir-lang/acvm-backend-barretenberg#247
ACVM: noir-lang/acvm#503

Documentation

• This PR requires documentation updates when merged.

  • I will submit a noir-lang/docs PR.
  • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[jfecher]

Waiting to review this until the other PR on mv/mem-op-predicate is merged

[TomAFrench]

This is currently using a patched ACVM and should not be merged until we've included the changes in a release.

[kevaundray]

What is the status of this PR?

[vezenovm]

This PR was originally created to avoid the execution error in ACVM with mem ops and predicates. This should be superseded by #2493. As per #2493 (comment) we should be able to then remove the inclusion of a predicate on the MemoryOp ACIR opcode as well.

[vezenovm]

Superseded by #2553