feat(attributes): enable custom attributes#2395
Merged
Conversation
Maddiaa0
changed the title
Maddiaa0
commented
Aug 22, 2023
Maddiaa0
requested review from
jfecher,
kevaundray and
vezenovm
and removed request for
jfecher,
kevaundray and
vezenovm
vezenovm
reviewed
Aug 22, 2023
Contributor
vezenovm
left a comment
vezenovm
left a comment
There was a problem hiding this comment.
I'm assuming you are going to add the feature flag work in a follow-up PR?
Member
Author
Yep, keeping it separate + making prs to the ci infrastructure to support feature flags |
5 tasks
jfecher
approved these changes
Aug 22, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
This is fine for now, although we will remove (this form of) custom attributes in the future.
We may re-add them sometime but the goal will be that attributes not in scope should still generate a compiler error to match rust's behavior here. Not issuing an error for custom attributes allows for typos to more easily go unnoticed.
TomAFrench
added a commit
that referenced
this pull request
Aug 22, 2023
* master: fix(acir): Attach locations to MemoryOps in ACIR (#2389) feat: Use equivalence information from equality assertions to simplify circuit (#2378) chore: fix body expr span (#2402) feat(attributes): enable custom attributes (#2395) chore: Remove `serde` from `noirc_frontend` (#2390) chore: allow parenthesizing in two type locations (#2388) chore(ci): automatically delete cache entries associated with closed PRs (#2342)
TomAFrench
added a commit
that referenced
this pull request
Aug 23, 2023
* master: (34 commits) chore: Decouple `noirc_abi` from frontend by introducing `PrintableType` (#2373) feat(brillig): Added locations for brillig artifacts (#2415) feat: Report compilation warnings before errors (#2398) chore: Rework `CrateGraph` to only have one root crate (#2391) chore: clippy fix (#2408) chore(deps): bump rustls-webpki from 0.101.1 to 0.101.4 (#2404) fix(acir): Attach locations to MemoryOps in ACIR (#2389) feat: Use equivalence information from equality assertions to simplify circuit (#2378) chore: fix body expr span (#2402) feat(attributes): enable custom attributes (#2395) chore: Remove `serde` from `noirc_frontend` (#2390) chore: allow parenthesizing in two type locations (#2388) chore(ci): automatically delete cache entries associated with closed PRs (#2342) feat: Perform more checks for compile-time arithmetic (#2380) chore: Remove `noirc_abi::FunctionSignature` and define in terms of HIR (#2372) feat: Update to `acvm` 0.22.0 (#2363) chore: Update committed ACIR artifacts (#2376) feat(ssa): Merge slices in if statements with witness conditions (#2347) chore: Separate frontend `Visibility` and `Distinctness` from the ABI (#2369) feat: add syntax for specifying function type environments (#2357) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes the ability to create custom attributes. This work comes after a discussion with the noir team to enable library flexibility.
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.