fix: simplification of overflowing integer operations#2153
Merged
Conversation
Contributor
Author
|
Also fixes #2098 |
kevaundray
previously approved these changes
Aug 7, 2023
Contributor
|
Just pending merge conflict resolution |
TomAFrench
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2045
Summary*
Instead of returning
Nonefor operations that will wrap the integer, we use thewrapping_*operations instead. I was worried initially that wrapping on a u128 then truncating afterward would result in a different value than a proper (e.g.)u5::suboperation but after a small amount of testing it seems to work fine.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.