feat!: Change CLI to default to new SSA code for compilation#2032
Merged
kevaundray merged 1 commit intomasterfrom Jul 25, 2023
Merged
feat!: Change CLI to default to new SSA code for compilation#2032kevaundray merged 1 commit intomasterfrom
kevaundray merged 1 commit intomasterfrom
Conversation
Member
Author
|
Currently blocked by AztecProtocol/barretenberg#626 as we want to get all ACIR tests passing in bberg before merging. |
jfecher
reviewed
Jul 25, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
LGTM. I'll approve once the prerequisite PR is merged.
Member
Author
|
On second thought we should probably push out a release before we merge this. |
kevaundray
approved these changes
Jul 25, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
The blocking PR has been merged so approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR does the minimal changes to move
nargoover to use the new SSA code by default. You can continue to use the old SSA by using thelegacy-ssaflag (which replacesexperimental-ssa) although this should be removed soon.Documentation
This PR requires documentation updates when merged.
References to
experimental-ssashould be removed. I would leavelegacy-ssaundocumented as it will be removed soon.Additional Context
PR Checklist*
cargo fmton default settings.BEGIN_COMMIT_OVERRIDE
feat(nargo)!: Default to new SSA code for compilation
END_COMMIT_OVERRIDE