Skip to content

chore: Compile ssa refactor test vectors#2023

Merged
kevaundray merged 1 commit intomasterfrom
kw/add-bb-tests
Jul 24, 2023
Merged

chore: Compile ssa refactor test vectors#2023
kevaundray merged 1 commit intomasterfrom
kw/add-bb-tests

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Jul 24, 2023

Description

Problem*

Resolves #2020

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

Note: These were not compiled using --flat-witness config flag

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely went through and reviewed each line manually

@kevaundray
Copy link
Contributor Author

Running these against barretenberg!

@kevaundray
Copy link
Contributor Author

I have created this branch in bb which is passing except for 9_conditional since all except one tests pass, its likely not a problem with the serialization of these files and a problem elsewhere, so merging

@kevaundray kevaundray added this pull request to the merge queue Jul 24, 2023
@kevaundray
Copy link
Contributor Author

Branch is here: AztecProtocol/barretenberg#626

Merged via the queue into master with commit 0444b52 Jul 24, 2023
@kevaundray kevaundray deleted the kw/add-bb-tests branch July 24, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create ACIR + witness artifacts for Barretenberg using experimental-ssa

2 participants