Skip to content

chore: --show-output by default #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfecher merged 6 commits into from
Jul 24, 2023
Merged

chore: --show-output by default #2019

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fceb6f3
show-output by default
Ethan-000 Jul 24, 2023
7653a65
remove --show-output as one of compileoptions
Ethan-000 Jul 24, 2023
896819f
Merge branch 'master' into e0/show-output
Ethan-000 Jul 24, 2023
65c6b35
merge master
Ethan-000 Jul 24, 2023
14ed0cb
clippy
Ethan-000 Jul 24, 2023
fbd1e2d
.
Ethan-000 Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/noirc_driver/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#![warn(unreachable_pub)]
#![warn(clippy::semicolon_if_nothing_returned)]

use clap::builder::ArgPredicate;
use clap::Args;
use fm::FileId;
use noirc_abi::FunctionSignature;
Expand Down Expand Up @@ -40,7 +41,7 @@ pub struct CompileOptions {
pub deny_warnings: bool,

/// Display output of `println` statements
#[arg(long)]
#[arg(long, default_value_if("prover_name", ArgPredicate::IsPresent, "true"))]
Comment thread
jfecher marked this conversation as resolved.
Outdated
pub show_output: bool,

/// Compile and optimize using the new experimental SSA pass
Expand Down