chore: implement basic workspace file functionality#1913
Merged
kevaundray merged 9 commits intomasterfrom Jul 13, 2023
unknown repository
Merged
chore: implement basic workspace file functionality#1913kevaundray merged 9 commits intomasterfrom unknown repository
kevaundray merged 9 commits intomasterfrom
unknown repository
Conversation
kevaundray
reviewed
Jul 12, 2023
added 3 commits
July 12, 2023 16:02
ghost
marked this pull request as ready for review
kevaundray
reviewed
Jul 12, 2023
kevaundray
reviewed
Jul 12, 2023
Member
|
I don't think we want a package manifest and a workspace manifest represented by the same struct. these two things are separate in my mind. |
kevaundray
reviewed
Jul 13, 2023
kevaundray
reviewed
Jul 13, 2023
kevaundray
reviewed
Jul 13, 2023
kevaundray
reviewed
Jul 13, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Great work, left some comments
kevaundray
approved these changes
Jul 13, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
implement basic workspace file functionality
Problem
step towards #794
Summary
PR Checklist
cargo fmton default settings.