fix: emit Opcodes in correct order from GeneratedAcir::radix_le_decompose#1903
Merged
kevaundray merged 1 commit intomasterfrom Jul 10, 2023
Merged
fix: emit Opcodes in correct order from GeneratedAcir::radix_le_decompose#1903kevaundray merged 1 commit intomasterfrom
Opcodes in correct order from GeneratedAcir::radix_le_decompose#1903kevaundray merged 1 commit intomasterfrom
Conversation
jfecher
reviewed
Jul 10, 2023
Contributor
jfecher
left a comment
There was a problem hiding this comment.
LGTM. I'll await another approving review however.
kevaundray
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Fixes test cases for #1729
Summary*
Previously we would
It's impossible to solve 1 and 2 without 3 so we have reordered these as
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.