feat: use RAM/ROM opcode when supported by the backend#1282
Merged
kevaundray merged 57 commits intomasterfrom Jun 14, 2023
Merged
feat: use RAM/ROM opcode when supported by the backend#1282kevaundray merged 57 commits intomasterfrom
kevaundray merged 57 commits intomasterfrom
Conversation
Contributor
Author
|
I don't understand why we are removing functionalities, using the proper opcode sooner is better than using a wrong one and changing it after. We want to reach an impossible target which is the backend-agnostic acir, and for what benefit? |
Contributor
Author
|
I removed the usage of |
Contributor
|
MacOS is taking nearly 5 hours to complete -- I'm going to redo the workflow |
Collaborator
|
Blocked by noir-lang/Planning#21. |
Collaborator
|
Good to merge? |
kevaundray
reviewed
Jun 13, 2023
kevaundray
approved these changes
Jun 14, 2023
This was referenced Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
This PR generates RAM and ROM opcodes if they are supported by the backend.
This will allow aztec backend to use UP loopk-ups for memory operations
Test additions / changes
We need a backend which support the opcodes.
Checklist
cargo fmtwith default settings.Documentation needs