feat(nargo): Remove usage of CompiledProgram in CLI code and use separate ABI/bytecode#1269
Merged
kevaundray merged 3 commits intomasterfrom May 2, 2023
Merged
feat(nargo): Remove usage of CompiledProgram in CLI code and use separate ABI/bytecode#1269kevaundray merged 3 commits intomasterfrom
CompiledProgram in CLI code and use separate ABI/bytecode#1269kevaundray merged 3 commits intomasterfrom
Conversation
kevaundray
reviewed
May 2, 2023
kevaundray
reviewed
May 2, 2023
kevaundray
reviewed
May 2, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Looks good overall, one comment about Result<bool, Error>
kevaundray
approved these changes
May 2, 2023
TomAFrench
added a commit
that referenced
this pull request
May 2, 2023
* master: (63 commits) feat(nargo): Remove usage of `CompiledProgram` in CLI code and use separate ABI/bytecode (#1269) feat: add integration tests for bitshift operators (#1272) chore: Replace explicit if-elses with `FieldElement::from<bool>()` for boolean fields (#1266) chore(noir): constrain expr; -> assert(expr); (#1276) chore: fix clippy warning (#1270) chore(ssa refactor): Add all remaining doc comments to ssa generation pass (#1256) chore(noir): Release 0.5.1 (#1264) fix: Add Poseidon examples into integration tests (#1257) chore(nargo): replace `aztec_backend` with `acvm-backend-barretenberg` (#1226) chore(noir): Release 0.5.0 (#1202) chore(ci): Utilize new workflow to build binaries (#1250) chore(ssa refactor): Fix loading from mutable parameters (#1248) fix(wasm): add std after dependencies (#1245) chore(ssa refactor): Fix no returns & duplicate main (#1243) chore(ssa refactor): Implement intrinsics (#1241) chore(ssa refactor): Implement first-class functions (#1238) chore: address clippy warnings (#1239) chore(ssa refactor): Implement function calls (#1235) chore(ssa refactor): Implement mutable and immutable variables (#1234) chore(ssa refactor): Fix recursive printing of blocks (#1230) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
This PR removes the usage of
CompiledProgramfrom the interface of the interface of the internal CLI functions, instead we pass ABI and bytecode separately.Using
CompiledProgramdoesn't really make sense anymore as now we havePreprocessedProgramso we need to explicitly create aCompiledProgramfrom the ABI and bytecode to pass it into a function where they'll be split again.As part of this I've removed
verify_cmd::verify_proofas it didn't really do much other thannargo::ops::verify_proofSteps 1 and 3 can instead be delegated to the caller, at which point they can just call
nargo::ops::verify_proofthemselves.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context
This would also be required if we were to support performing actions against contract functions in nargo (as these are not represented as
CompiledPrograms