Conversation
* master: chore: address clippy warnings (#1239) chore(ssa refactor): Implement function calls (#1235) chore(ssa refactor): Implement mutable and immutable variables (#1234) chore(ssa refactor): Fix recursive printing of blocks (#1230) feat(noir): added assert keyword (#1227) chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225) feat(noir): added `distinct` keyword (#1219)
vezenovm
commented
Apr 28, 2023
| outputs | ||
| } | ||
|
|
||
| fn prepare_outputs_no_count( |
Contributor
Author
There was a problem hiding this comment.
This new method prepare_outputs_no_count was created with the addition of variable output sizes. It feels a bit hacky, but all integration tests do pass. Do we think this is fine for now or should I add logic to expose backend specific information on variable output sizes of blackbox funcs?
Contributor
Author
|
Closing in favor of #1379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1154
Description
This adds a foreign function to enable recursive verification of proofs.
Summary of changes
A new std lib method was added:
Although this function signature is not final as I would like to remove the key hash field and have it be handled by the compiler. The key hash will have to be specific to a backend and we cannot rely on the compiler to generate the key hash without backend interop.
TODO: include a clean way to generate inner recursive proofs with nargo. The barretenberg backend requries a different hash type for recursive proofs (it using pedersen-blake3 for efficiency), however, the Noir requries a keccak based prover in order to be compatible with the Solidity verifier. This is why a new RecursiveProver type was added to the DSL package.
Dependency additions / changes
Currently referencing these drafts PRs:
aztec_backend: noir-lang/acvm-backend-barretenberg#146
acvm: noir-lang/acvm#234
barretenberg-sys: noir-lang/barretenberg-sys#26
barretenberg: AztecProtocol/barretenberg#383
Test additions / changes
There is a new
recursiontest that calls the newverify_proofforeign function. It currently fetches its proof data from this backend recursion test, as I still have to add a clean way to generate recursive proofs using nargo.Checklist
cargo fmtwith default settings.Documentation needs
Additional context