fix(nargo): restore nargo codegen-verifier functionality#1185
Merged
kevaundray merged 1 commit intomasterfrom Apr 20, 2023
Merged
fix(nargo): restore nargo codegen-verifier functionality#1185kevaundray merged 1 commit intomasterfrom
nargo codegen-verifier functionality#1185kevaundray merged 1 commit intomasterfrom
Conversation
kevaundray
approved these changes
Apr 19, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 24, 2023
* master: chore: update flake version to match current release (#1204) feat!: Switch to aztec_backend that uses upstream BB & UltraPlonk (#1114) chore(ssa refactor): Add Context structs and start ssa gen pass (#1196) chore(ssa): Replace JmpIf with BrIf (#1193) chore(noir): Release 0.4.1 (#1164) chore(ssa refactor): Add DenseMap and SparseMap types (#1184) feat: bump noir-source-resolver version (#1182) chore(deps): bump h2 from 0.3.16 to 0.3.18 (#1186) fix(nargo): restore `nargo codegen-verifier` functionality (#1185) chore: simplify setup code in `noir_integration` test (#1180) feat: Add Poseidon-BN254 hash functions (#1176)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
Looks like we got a bit ahead of ourselves and started using
eth_contract_from_vkagainst a commit ofaztec_backendwhere that isn't implemented yet. If you runnargo codegen-verifieron v0.4.0 you getThis PR reverts to
eth_contract_from_csand adds an integration test that if you runcodegen-verifierthe command succeeds and you get some file created.I haven't made any change to
nargo::ops::codegen_verifieras that's backend agnostic and I don't want to make a breaking change to fix this.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context