chore: switch integration tests to mirror CLI usage#1179
Merged
Conversation
6 tasks
Member
Author
|
@kevaundray This adds another ~10mins to the ubuntu run (up from 18mins) |
6 tasks
Member
Author
|
I've separated all the readability improvements into #1180 so we can merge those even in the case we don't go ahead with this change. (plus it will highlight the substantive changes here more clearly) |
Contributor
|
Ah thats horrible |
Contributor
|
What is the reasoning for the extra 10 minutes of runtime? |
Member
Author
|
Let's park this pending #1180 |
b38221e to
97e5bb2
Compare
97e5bb2 to
86cfa3f
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1177 (comment)
Description
Summary of changes
This PR changes the integration tests to work using the CLI directly to ensure exact parity between this and real-world usage. i.e. rather than using
prove_and_verifywe actually usenargo proveandnargo verify.As part of this I've done some general refactoring as this code is unnecessarily complex (3 layers of nesting to just iterate through test cases).
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context