chore: let simple_optimization optimize values whose dependent values changed#11784
Merged
chore: let simple_optimization optimize values whose dependent values changed#11784
simple_optimization optimize values whose dependent values changed#11784Conversation
aakoshh
reviewed
Mar 5, 2026
aakoshh
reviewed
Mar 5, 2026
aakoshh
reviewed
Mar 5, 2026
aakoshh
approved these changes
Mar 5, 2026
Contributor
aakoshh
left a comment
There was a problem hiding this comment.
Nice find!
I'd still rename them to show that this is not necessarily a change, but being "tainted" by a changed instruction in their ancestry.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: f141bc7 | Previous: 85aae28 | Ratio |
|---|---|---|---|
private-kernel-reset |
0.053 s |
0.042 s |
1.26 |
rollup-block-root |
0.003 s |
0.002 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
No issue, just an optimization I noticed that could make the hashmap regression in #11659 go away
Summary
Compare the two commits where in the first one the
poseidon2_permutationcall wasn't optimized and in the second where it is.Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.