Skip to content

chore: let simple_optimization optimize values whose dependent values changed#11784

Merged
asterite merged 5 commits intomasterfrom
ab/simple_optimization_optimization
Mar 5, 2026
Merged

chore: let simple_optimization optimize values whose dependent values changed#11784
asterite merged 5 commits intomasterfrom
ab/simple_optimization_optimization

Conversation

@asterite
Copy link
Copy Markdown
Collaborator

@asterite asterite commented Mar 5, 2026

Description

Problem

No issue, just an optimization I noticed that could make the hashmap regression in #11659 go away

Summary

Compare the two commits where in the first one the poseidon2_permutation call wasn't optimized and in the second where it is.

Additional Context

User Documentation

Check one:

  • No user documentation needed.
  • Changes in docs/ included in this PR.
  • [For Experimental Features] Changes in docs/ to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Copy Markdown
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

I'd still rename them to show that this is not necessarily a change, but being "tainted" by a changed instruction in their ancestry.

@asterite asterite enabled auto-merge March 5, 2026 17:23
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: f141bc7 Previous: 85aae28 Ratio
private-kernel-reset 0.053 s 0.042 s 1.26
rollup-block-root 0.003 s 0.002 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@asterite asterite added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit c868cfc Mar 5, 2026
137 checks passed
@asterite asterite deleted the ab/simple_optimization_optimization branch March 5, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants