Skip to content

fix: correct index out of bounds location #11685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asterite merged 6 commits into from
Feb 25, 2026
Merged

fix: correct index out of bounds location #11685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
10d190b
fix: correct index out of bounds location
asterite Feb 25, 2026
bfa97a2
Remove extra argument not found in Prover.toml from test program
asterite Feb 25, 2026
9d417a7
chore: update snapshot
TomAFrench Feb 25, 2026
bc595d7
Update snapshot
asterite Feb 25, 2026
e73f3dd
Merge branch 'ab/improve-index-out-of-bounds-location' of github.com:…
asterite Feb 25, 2026
6c8b20e
Remove snap.new
asterite Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,8 @@ impl FunctionContext<'_> {
location: Location,
length: Option<ValueId>,
) -> Result<Values, RuntimeError> {
self.builder.set_location(location);

// base_index = index * type_size
let index = self.make_array_index(index);
let type_size_usize = Self::convert_type(element_type).size_of_type();
Expand Down Expand Up @@ -564,11 +566,7 @@ impl FunctionContext<'_> {
// so it's okay to use unchecked operations. The SSA interpreter has been updated to have similar semantics.
let unchecked = true;

let base_index = self.builder.set_location(location).insert_binary(
index,
BinaryOp::Mul { unchecked },
type_size,
);
let base_index = self.builder.insert_binary(index, BinaryOp::Mul { unchecked }, type_size);

let mut field_index = 0u128;
Ok(Self::map_type(element_type, |typ| {
Expand Down
2 changes: 1 addition & 1 deletion test_programs/execution_failure/regression_10238/src/main.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
fn main(b: i64, mut c: bool) -> pub Field {
fn main(b: i64) -> pub Field {
if ((6863985126385003285_i64 - b) != 0) {
10
} else {
Expand Down
6 changes: 3 additions & 3 deletions ..._cli/tests/snapshots/compile_success_with_bug/regression_9872/execute__tests__stderr.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading