feat: only print SSA optimization result if it produced changes#11587
feat: only print SSA optimization result if it produced changes#11587
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 5c5ef6a | Previous: 11c71e4 | Ratio |
|---|---|---|---|
rollup-block-root-first-empty-tx |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
One note of caution here is that I can imagine that it will confuse Claude greatly if we don't document this in the necessary places. |
|
I guess we can add a new flag to hide passes that don't produce changes. |
|
I agree that it would be nice to have a CLI flag to turn this behaviour on, and show every step by default. |
|
Done! Added a new |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 5c5ef6a | Previous: 11c71e4 | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.08 s |
0.06 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem
No issue.
Summary
While working on #11586 and trying to find which SSA pass produced a change that I had to look into, I realized that we could avoid showing the result of an SSA pass if it didn't modify the previous SSA.
Initially I thought of showing this as "After some optimization: (no changes)" but then I found all that output to not be that useful. So now only the steps that produced changes are shown.
For example, for this Noir code we now get this output instead of that plus 30+ steps that show an SSA unchanged:
we now get this output:
Output of `nargo compile --show-ssa`
Additional Context
Let me know if you'd prefer to show the "skipped" steps instead, or feel free to push to this PR. (or we could make it configurable, I'm case you really want to see a proof that a pass ran but it did nothing)
User Documentation
Check one:
PR Checklist
cargo fmton default settings.