chore(ssa): Run mem2reg before preprocess functions#11333
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
181015 ns/iter (± 1806) |
264330 ns/iter (± 3556) |
0.68 |
perfectly_parallel_opcodes |
169438 ns/iter (± 501) |
232197 ns/iter (± 3953) |
0.73 |
perfectly_parallel_batch_inversion_opcodes |
2469014 ns/iter (± 19690) |
2802943 ns/iter (± 6636) |
0.88 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
155 s |
157 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
167 s |
163 s |
1.02 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
206 s |
209 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
370 s |
373 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
164 s |
163 s |
1.01 |
test_report_noir-lang_noir-bignum_ |
172 s |
168 s |
1.02 |
test_report_noir-lang_noir_bigcurve_ |
310 s |
245 s |
1.27 |
test_report_noir-lang_sha256_ |
18 s |
18 s |
1 |
test_report_noir-lang_sha512_ |
13 s |
16 s |
0.81 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
test_report_noir-lang_noir_bigcurve_ |
310 s |
245 s |
1.27 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.043 s |
0.043 s |
1 |
private-kernel-reset |
0.222 s |
0.221 s |
1.00 |
private-kernel-tail |
0.007 s |
0.009 s |
0.78 |
rollup-block-root-first-empty-tx |
0.003 s |
0.003 s |
1 |
rollup-block-root-single-tx |
0.003 s |
0.002 s |
1.50 |
rollup-block-root |
0.004 s |
0.003 s |
1.33 |
rollup-checkpoint-merge |
0.003 s |
0.003 s |
1 |
rollup-checkpoint-root-single-block |
26.7 s |
19.9 s |
1.34 |
rollup-checkpoint-root |
27.8 s |
20.1 s |
1.38 |
rollup-root |
0.004 s |
0.004 s |
1 |
rollup-tx-base-private |
0.339 s |
0.341 s |
0.99 |
rollup-tx-base-public |
0.26 s |
0.218 s |
1.19 |
rollup-tx-merge |
0.002 s |
0.002 s |
1 |
semaphore-depth-10 |
0.009 s |
0.009 s |
1 |
sha512-100-bytes |
0.054 s |
0.057 s |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
0.003 s |
0.002 s |
1.50 |
rollup-block-root |
0.004 s |
0.003 s |
1.33 |
rollup-checkpoint-root-single-block |
26.7 s |
19.9 s |
1.34 |
rollup-checkpoint-root |
27.8 s |
20.1 s |
1.38 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Artifact Size
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
1020.7 KB |
1020.8 KB |
1.00 |
private-kernel-reset |
2161.9 KB |
2168.1 KB |
1.00 |
private-kernel-tail |
486.7 KB |
493.1 KB |
0.99 |
rollup-block-root-first-empty-tx |
224.9 KB |
224.9 KB |
1 |
rollup-block-root-single-tx |
228.6 KB |
228.6 KB |
1 |
rollup-block-root |
300.3 KB |
300.3 KB |
1 |
rollup-checkpoint-merge |
387.4 KB |
387.4 KB |
1 |
rollup-checkpoint-root-single-block |
48654.1 KB |
48651.4 KB |
1.00 |
rollup-checkpoint-root |
48717.5 KB |
48712.8 KB |
1.00 |
rollup-root |
419 KB |
419 KB |
1 |
rollup-tx-base-private |
5452.2 KB |
5452.2 KB |
1 |
rollup-tx-base-public |
4770.1 KB |
4770.1 KB |
1 |
rollup-tx-merge |
175.2 KB |
175.2 KB |
1 |
semaphore-depth-10 |
551.5 KB |
551 KB |
1.00 |
sha512-100-bytes |
473 KB |
473 KB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Opcode count
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
19695 opcodes |
19695 opcodes |
1 |
private-kernel-reset |
86626 opcodes |
86626 opcodes |
1 |
private-kernel-tail |
9073 opcodes |
9073 opcodes |
1 |
rollup-block-root-first-empty-tx |
1082 opcodes |
1082 opcodes |
1 |
rollup-block-root-single-tx |
969 opcodes |
969 opcodes |
1 |
rollup-block-root |
2173 opcodes |
2173 opcodes |
1 |
rollup-checkpoint-merge |
1716 opcodes |
1716 opcodes |
1 |
rollup-checkpoint-root-single-block |
1831644 opcodes |
1831644 opcodes |
1 |
rollup-checkpoint-root |
1832840 opcodes |
1832840 opcodes |
1 |
rollup-root |
2464 opcodes |
2464 opcodes |
1 |
rollup-tx-base-private |
302267 opcodes |
302267 opcodes |
1 |
rollup-tx-base-public |
257974 opcodes |
257974 opcodes |
1 |
rollup-tx-merge |
1304 opcodes |
1304 opcodes |
1 |
semaphore-depth-10 |
5699 opcodes |
5699 opcodes |
1 |
sha512-100-bytes |
13173 opcodes |
13173 opcodes |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
2.382 s |
2.398 s |
0.99 |
private-kernel-reset |
7.638 s |
7.968 s |
0.96 |
private-kernel-tail |
1.97 s |
2.456 s |
0.80 |
rollup-block-root-first-empty-tx |
1.55 s |
1.644 s |
0.94 |
rollup-block-root-single-tx |
1.49 s |
1.49 s |
1 |
rollup-block-root |
1.54 s |
1.32 s |
1.17 |
rollup-checkpoint-merge |
1.554 s |
1.58 s |
0.98 |
rollup-checkpoint-root-single-block |
407 s |
394 s |
1.03 |
rollup-checkpoint-root |
409 s |
349 s |
1.17 |
rollup-root |
1.612 s |
1.612 s |
1 |
rollup-tx-base-private |
19.56 s |
20.14 s |
0.97 |
rollup-tx-base-public |
82.48 s |
68.84 s |
1.20 |
rollup-tx-merge |
1.272 s |
1.5 s |
0.85 |
semaphore-depth-10 |
0.927 s |
0.907 s |
1.02 |
sha512-100-bytes |
1.619 s |
1.574 s |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Brillig Artifact Size
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
751.2 KB |
751.8 KB |
1.00 |
private-kernel-reset |
656.9 KB |
666.1 KB |
0.99 |
private-kernel-tail |
299.4 KB |
305.6 KB |
0.98 |
rollup-block-root-first-empty-tx |
241.3 KB |
244.5 KB |
0.99 |
rollup-block-root-single-tx |
245.4 KB |
246.3 KB |
1.00 |
rollup-block-root |
306 KB |
306.7 KB |
1.00 |
rollup-checkpoint-merge |
276.8 KB |
276.8 KB |
1 |
rollup-checkpoint-root-single-block |
554.2 KB |
554.1 KB |
1.00 |
rollup-checkpoint-root |
596.1 KB |
596.3 KB |
1.00 |
rollup-root |
424.7 KB |
424.7 KB |
1 |
rollup-tx-base-private |
618.9 KB |
619.1 KB |
1.00 |
rollup-tx-base-public |
768.8 KB |
768.7 KB |
1.00 |
rollup-tx-merge |
197.3 KB |
197.3 KB |
1 |
semaphore-depth-10 |
2068.8 KB |
2068.6 KB |
1.00 |
sha512-100-bytes |
161.6 KB |
161.4 KB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Brillig Compilation Time
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
1.232 s |
1.284 s |
0.96 |
private-kernel-reset |
1.27 s |
1.264 s |
1.00 |
private-kernel-tail |
0.912 s |
1.1 s |
0.83 |
rollup-block-root-first-empty-tx |
1.51 s |
1.622 s |
0.93 |
rollup-block-root-single-tx |
1.45 s |
1.47 s |
0.99 |
rollup-block-root |
1.46 s |
1.25 s |
1.17 |
rollup-checkpoint-merge |
1.5 s |
1.512 s |
0.99 |
rollup-checkpoint-root-single-block |
2.13 s |
1.8 s |
1.18 |
rollup-checkpoint-root |
2.01 s |
1.69 s |
1.19 |
rollup-root |
1.526 s |
1.498 s |
1.02 |
rollup-tx-base-private |
1.632 s |
1.682 s |
0.97 |
rollup-tx-base-public |
1.698 s |
1.476 s |
1.15 |
rollup-tx-merge |
1.212 s |
1.462 s |
0.83 |
semaphore-depth-10 |
0.24 s |
0.23 s |
1.04 |
sha512-100-bytes |
0.202 s |
0.201 s |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Brillig Execution Time
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.033 s |
0.033 s |
1 |
private-kernel-reset |
0.102 s |
0.101 s |
1.01 |
private-kernel-tail |
0.004 s |
0.005 s |
0.80 |
rollup-block-root-first-empty-tx |
0.003 s |
0.003 s |
1 |
rollup-block-root-single-tx |
0.002 s |
0.002 s |
1 |
rollup-block-root |
0.003 s |
0.002 s |
1.50 |
rollup-checkpoint-merge |
0.002 s |
0.002 s |
1 |
rollup-root |
0.002 s |
0.002 s |
1 |
rollup-tx-base-private |
0.035 s |
0.035 s |
1 |
rollup-tx-base-public |
0.045 s |
0.036 s |
1.25 |
rollup-tx-merge |
0.001 s |
0.002 s |
0.50 |
semaphore-depth-10 |
0.024 s |
0.025 s |
0.96 |
sha512-100-bytes |
0.017 s |
0.017 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
rollup-block-root |
0.003 s |
0.002 s |
1.50 |
rollup-tx-base-public |
0.045 s |
0.036 s |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
288.71 MB |
288.71 MB |
1 |
private-kernel-reset |
503.82 MB |
503.98 MB |
1.00 |
private-kernel-tail |
261.8 MB |
261.97 MB |
1.00 |
rollup-block-root-first-empty-tx |
360.35 MB |
360.35 MB |
1 |
rollup-block-root-single-tx |
360.35 MB |
360.35 MB |
1 |
rollup-block-root |
360.35 MB |
360.35 MB |
1 |
rollup-checkpoint-merge |
360.35 MB |
360.35 MB |
1 |
rollup-checkpoint-root-single-block |
11340 MB |
11340 MB |
1 |
rollup-checkpoint-root |
11340 MB |
11340 MB |
1 |
rollup-root |
361.11 MB |
361.15 MB |
1.00 |
rollup-tx-base-private |
1090 MB |
1090 MB |
1 |
rollup-tx-base-public |
3040 MB |
3040 MB |
1 |
rollup-tx-merge |
360.35 MB |
360.35 MB |
1 |
semaphore_depth_10 |
98.18 MB |
98.16 MB |
1.00 |
sha512_100_bytes |
184.87 MB |
186.19 MB |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: 6d4fe35 | Previous: bb12309 | Ratio |
|---|---|---|---|
private-kernel-inner |
271.79 MB |
271.8 MB |
1.00 |
private-kernel-reset |
309.42 MB |
309.45 MB |
1.00 |
private-kernel-tail |
260.36 MB |
260.46 MB |
1.00 |
rollup-block-root |
361.59 MB |
361.59 MB |
1 |
rollup-checkpoint-merge |
361.66 MB |
361.66 MB |
1 |
rollup-checkpoint-root-single-block |
1760 MB |
1760 MB |
1 |
rollup-checkpoint-root |
1760 MB |
1760 MB |
1 |
rollup-root |
362.09 MB |
362.1 MB |
1.00 |
rollup-tx-base-private |
545.88 MB |
545.88 MB |
1 |
rollup-tx-base-public |
487.15 MB |
487.15 MB |
1 |
rollup-tx-merge |
361.15 MB |
361.15 MB |
1 |
semaphore_depth_10 |
74.24 MB |
74.23 MB |
1.00 |
sha512_100_bytes |
72.52 MB |
72.52 MB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
jfecher
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
We had to previously disable running mem2reg earlier in the SSA pipeline #9987.
Summary
I went to investigate the cause of the bug and found that the aztec-nr tests pass with our current mem2reg. I also ran this reactivation against the full aztec-packages CI AztecProtocol/aztec-packages#19871 and it passed.
Additional Context
I am still working on determining the exact commit which fixed this bug.
User Documentation
Check one:
PR Checklist
cargo fmton default settings.